Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker multi-arch support with Buildx #1319

Merged
merged 1 commit into from
May 27, 2021
Merged

Add Docker multi-arch support with Buildx #1319

merged 1 commit into from
May 27, 2021

Conversation

blairdrummond
Copy link
Contributor

This adds Docker support to extra CPU architectures (like arm) using Docker's Buildx action

You can see what that looks like on Dockerhub

And how it lets Datasette run on a Raspberry Pi (top is my dockerhub, bottom is upstream)

Screenshot from 2021-05-08 15-32-25

The workflow log here (I subbed blairdrummond for datasetteproject in my branch)

@simonw
Copy link
Owner

simonw commented May 27, 2021

This is so cool! I wonder how I can best test it? I have a Raspberry Pi I should dig out to try this.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1319 (cfca570) into main (1b69753) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.02%     
==========================================
  Files          34       34              
  Lines        4255     4255              
==========================================
+ Hits         3894     3895       +1     
+ Misses        361      360       -1     
Impacted Files Coverage Δ
datasette/utils/__init__.py 94.31% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b69753...cfca570. Read the comment docs.

@simonw
Copy link
Owner

simonw commented May 27, 2021

Started a conversation about this on Twitter. Ideally I'd like to push an alpha release to Docker Hub so people can start testing these out before they make it into an official non-alpha release.

@simonw
Copy link
Owner

simonw commented May 27, 2021

It looks like all I need to do to ship an alpha version to Docker Hub is NOT point the latest tag at it after it goes live:

docker tag $REPO:${GITHUB_REF#refs/tags/} $REPO:latest
docker push $REPO:${VERSION_TAG}
docker push $REPO:latest

@simonw
Copy link
Owner

simonw commented May 27, 2021

OK, since I have a mechanism for deploying alpha versions now I'm going to merge this and use it to publish 0.57a1.

@simonw simonw merged commit 89822d1 into simonw:main May 27, 2021
simonw added a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants